Re: [PATCH 60/80] tty: extract the pty init time special cases

[bmckinlay]

Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote on 01/22/2009 07:40:42 AM:
> > This patch seems to break any other pseudo tty drivers, (ie 
driver->type
> > ==TTY_DRIVER_TYPE_PTY) since not all the tty functions needed for the
> > driver's new driver->install method are exported from tty_io.c.  The
> > function symbols that need to be exported from /drivers/char/tty_io.c 
are

> I did ask at the time what other PTY drivers there were as and
> what .config case in the kernel needed those symbols. If you only need
> them for an out of tree driver then they can stay out of tree until that
> driver is merged.

So you are saying that if I merge my ptyx module into the kernel tree THEN 
these
exports would be added?  They would have to be, since I would still want 
my 
driver to be a module instead of statically linked with the kernel like 
pty is.

I think the fact that you had to "ask at the time what other PTY drivers 
there 
were" indicates that these symbols should have been simply exported to 
avoid 
any problems with out of tree PTY drivers.

By not exporting these symbols it means that the Linux kernel is now 
forcing 
anyone who wants to develop a PTY type TTY driver to be merged into the 
kernel 
tree by not exporting these TTY functions. This doesn't seem very "open 
and 
flexible".





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/