Re: [PATCH v4] softlockup: remove hung_task_check_count

[Ingo Molnar]

* Mandeep Singh Baines <msb@xxxxxxxxxx> wrote:

> The design was proposed by Frédéric Weisbecker. Peter Zijlstra suggested 
> the use of RCU.

ok, this looks _much_ cleaner.

One question:

> -	read_lock(&tasklist_lock);
> +	rcu_read_lock();
>  	do_each_thread(g, t) {
> -		if (!--max_count)
> +		if (need_resched())
>  			goto unlock;

Isnt it dangerous to skip a check just because we got marked for 
reschedule? Since it runs so rarely it could by accident be preempted and 
we'd not get any checking done for a long time.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/