Re: [PATCH 1/2] cris: introduce asm/swab.h

[Jaswinder Singh Rajput]

On Wed, Jan 14, 2009 at 8:56 AM, Harvey Harrison
<harvey.harrison@xxxxxxxxx> wrote:
> Adjust the arch overrides to the new names as well.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> ---
> Jesper, I noticed that my patch was the only one for CRIS this merge
> window (at least looking at linux-next), I hope you're OK with me
> sending this directly to Linus.  It's just code movement, so I'm
> confident it's not going to break anything.
>
>  arch/cris/include/arch-v10/arch/byteorder.h |   26 -----------------------
>  arch/cris/include/arch-v10/arch/swab.h      |   30 +++++++++++++++++++++++++++
>  arch/cris/include/arch-v32/arch/byteorder.h |   20 ------------------
>  arch/cris/include/arch-v32/arch/swab.h      |   24 +++++++++++++++++++++
>  arch/cris/include/asm/Kbuild                |    1 +
>  arch/cris/include/asm/byteorder.h           |   20 +-----------------
>  arch/cris/include/asm/swab.h                |    8 +++++++
>  7 files changed, 64 insertions(+), 65 deletions(-)
>
> diff --git a/arch/cris/include/arch-v10/arch/swab.h b/arch/cris/include/arch-v10/arch/swab.h
> new file mode 100644
> index 0000000..e4e847d
> --- /dev/null
> +++ b/arch/cris/include/arch-v10/arch/swab.h
> @@ -0,0 +1,30 @@
> +#ifndef _CRIS_ARCH_SWAB_H
> +#define _CRIS_ARCH_SWAB_H
> +
> +#include <asm/types.h>

Please replace #include <asm/types.h> with #include <linux/types.h>
otherwise you will get following 'make headers_check' warnings:
  usr/include/asm/swab.h:4: include of <linux/types.h> is preferred
over <asm/types.h>
  usr/include/asm/swab.h:14: found __[us]{8,16,32,64} type without
#include <linux/types.h>

> diff --git a/arch/cris/include/arch-v32/arch/swab.h b/arch/cris/include/arch-v32/arch/swab.h
> new file mode 100644
> index 0000000..1152329
> --- /dev/null
> +++ b/arch/cris/include/arch-v32/arch/swab.h
> @@ -0,0 +1,24 @@
> +#ifndef _ASM_CRIS_ARCH_SWAB_H
> +#define _ASM_CRIS_ARCH_SWAB_H
> +
> +#include <asm/types.h>

ditto.

If possible, please also fix your other patches which are in queue.

--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/