Re: [RFC] per-CPU cryptd thread implementation based on workqueue

From: Herbert Xu
Date: Wed Jan 21 2009 - 22:04:19 EST

On Thu, Jan 22, 2009 at 10:32:17AM +0800, Huang Ying wrote:
> This is the first attempt to use a dedicate workqueue for crypto. It is
> not intended to be merged. Please feedback your comments, especially on
> desgin.

Thanks for the patch!

> + spin_lock_init(&cpu_queue->lock);

Since we're switching to per-cpu queues it would be good to just
kill the spin lock. AFAICS the only place you really need it is
in cryptd_tfm_in_queue. That's just used for debugging so we can
just kill it and lose this spin lock.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at