Re: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers

[Arnd Bergmann]

On Wednesday 21 January 2009, David Miller wrote:
> There seems to be a large precendence for this in other USB drivers,
> both for networking and storage.  Probably a mutex or other locking
> hierarchy issue.
> 
> Really, I would just apply this patch as-is.  It works, it's pretty
> clean, and every retort has been a misunderstanding or extreme
> nit-picking :-)

Ok, fair enough. Please add my Acked-by then.

On a related topic, can we put something in place that can check for
this error at run-time, like a WARN_ON(is_kernel_stack(addr)) in
dma_map_single?
Since I only copied this code from elsewhere, I would suspect that
there are lots of similar bugs that never get found on common hardware
otherwise.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/