Re: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers

From: Oliver Neukum
Date: Tue Jan 20 2009 - 18:36:35 EST

Am Wednesday 21 January 2009 00:23:45 schrieb David Miller:
> > GFP_NOIO seems out of place in a network driver: there is nothing
> > wrong with waiting for I/O here, so plain GFP_KERNEL should be fine.
> There seems to be a large precendence for this in other USB drivers,
> both for networking and storage.  Probably a mutex or other locking
> hierarchy issue.

Usb storage uses a lot of infrastructure in error handling. As a storage
interface and another interface can share a device and be reset only
together. All drivers' reset handling must be written as if they were
block devices. Therefore you see a lot of GFP_NOIO in USB.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at