Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading(-git7 is ok)

From: David Miller
Date: Tue Jan 13 2009 - 15:27:22 EST


From: "Matt Carlson" <mcarlson@xxxxxxxxxxxx>
Date: Tue, 13 Jan 2009 10:39:48 -0800

> On Sun, Jan 11, 2009 at 01:39:29PM -0800, David Miller wrote:
> > From: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> > Date: Sun, 11 Jan 2009 12:24:58 +0000
> >
> > > Other drivers will load the firmware later, at the time the device is
> > > brought up. This means that even if you build the driver into the kernel
> > > without its firmware, it can still request the firmware later, when you
> > > try to start _using_ it. And when the file system is available.
> >
> > For example, for mounting an NFS root using that device.... Oh, will I
> > need an initramfs for that once you pull the firmware-in-kernel
> > option?
> >
> > To me, device probe is in fact the place to fail firmware discovery
> > for networking devices. Because such a failure can mean you can't
> > mount your root filesystem.
>
> David, is this the direction you want to take the fix? I'm sitting on
> a patch that elaborates on David Woodhouse's work which moves the
> request_firmware call to tg3_open(). Before I posted it for comment,
> I wanted to make sure the patch is moving in the right direction.

You can post it, sure.

But it doesn't actually fix the nfsroot case, that will still be
broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/