Re: [PATCH 22/24] i386: add TRACE_IRQS_OFF for the nmi

[Peter Zijlstra]

On Mon, 2009-01-12 at 19:39 +0100, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> 
> > On Tue, 2008-09-09 at 21:56 +0200, heukelum@xxxxxxxxxxx wrote:
> > > From: Alexander van Heukelum <heukelum@xxxxxxxxxxx>
> > > 
> > > At this point interrupts are off, so let's inform the tracing
> > > code of that fact before calling into C.
> > 
> > Sorry but this is an obvious dud, lockdep (and thus the irq state
> > tracer) aren't nmi safe.
> > 
> > Ingo, please revert, as people are already seeing lockdep warnings due
> > to this.
> 
> done - reverted it in tip/x86/urgent, see the commit below. Is that all 
> that we need, wasnt there a 64-bit side done too?

I had a _very_ quick peek but couldn't fine one, Alexander, does your
memory go back that far? :-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/