Re: [PATCH 22/24] i386: add TRACE_IRQS_OFF for the nmi

[Ingo Molnar]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Tue, 2008-09-09 at 21:56 +0200, heukelum@xxxxxxxxxxx wrote:
> > From: Alexander van Heukelum <heukelum@xxxxxxxxxxx>
> > 
> > At this point interrupts are off, so let's inform the tracing
> > code of that fact before calling into C.
> 
> Sorry but this is an obvious dud, lockdep (and thus the irq state
> tracer) aren't nmi safe.
> 
> Ingo, please revert, as people are already seeing lockdep warnings due
> to this.

done - reverted it in tip/x86/urgent, see the commit below. Is that all 
that we need, wasnt there a 64-bit side done too?

	Ingo

--------------->