Re: reiserfs broken "unknown uniqueness" (commit c1eaa26b671299b3ec01d40c6c71ee19a4f81517)

From: Jeff Chua
Date: Sun Jan 04 2009 - 07:53:39 EST

It's fixed in the link to this one ...

reiserfs broken with 2.6.28-17244-gb58602a


Jeff.


On Sun, Jan 4, 2009 at 7:24 PM, Robin H. Johnson
> Reiserfs broken recently, git bisect narrows it down to commit
> c1eaa26b671299b3ec01d40c6c71ee19a4f81517.
>
> [ 52.365262] ReiserFS: warning: vs-500: unknown uniqueness -30719
> ...
> [27630.378732] ReiserFS: warning: vs-500: unknown uniqueness -30720
> (and many more of the same with one of those two numbers on the end).
>

Delivered-To: jeff.chua.linux@xxxxxxxxx
Received: by 10.114.150.16 with SMTP id x16cs32835wad;
Fri, 2 Jan 2009 05:24:04 -0800 (PST)
Received: by 10.214.25.3 with SMTP id 3mr14860066qay.337.1230902643500;
Fri, 02 Jan 2009 05:24:03 -0800 (PST)
Return-Path: <linux-kernel-owner@xxxxxxxxxxxxxxx>
Received: from vger.kernel.org (vger.kernel.org [209.132.176.167])
by mx.google.com with ESMTP id 30si48280346yxk.37.2009.01.02.05.23.39;
Fri, 02 Jan 2009 05:24:03 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@xxxxxxxxxxxxxxx designates 209.132.176.167 as permitted sender) client-ip=209.132.176.167;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@xxxxxxxxxxxxxxx designates 209.132.176.167 as permitted sender) smtp.mail=linux-kernel-owner@xxxxxxxxxxxxxxx
Received: (majordomo@xxxxxxxxxxxxxxx) by vger.kernel.org via listexpand
id S1758118AbZABNX0 (ORCPT <rfc822;fedorabass@xxxxxxxxx>
+ 49 others); Fri, 2 Jan 2009 08:23:26 -0500
Received: (majordomo@xxxxxxxxxxxxxxx) by vger.kernel.org id S1757305AbZABNXN
(ORCPT <rfc822;linux-kernel-outgoing>);
Fri, 2 Jan 2009 08:23:13 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:43737 "EHLO
ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1757048AbZABNXL (ORCPT
<rfc822;linux-kernel@xxxxxxxxxxxxxxx>);
Fri, 2 Jan 2009 08:23:11 -0500
Received: from viro by ZenIV.linux.org.uk with local (Exim 4.68 #1 (Red Hat Linux))
id 1LIjzY-00068t-8L; Fri, 02 Jan 2009 13:23:08 +0000
Date: Fri, 2 Jan 2009 13:23:08 +0000
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
To: Marc Koschewski <marc@xxxxxxxxxxxxxxx>
Cc: Linux-LKLM <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: reiserfs broken with 2.6.28-17244-gb58602a
Message-ID: <20090102132308.GE28946@xxxxxxxxxxxxxxxxxx>
References: <20090102083645.GA3635@stiffy>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090102083645.GA3635@stiffy>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@xxxxxxxxxxxxxxx
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@xxxxxxxxxxxxxxx

On Fri, Jan 02, 2009 at 09:38:11AM +0100, Marc Koschewski wrote:
> Hi!
>
> I just booted into a 2.6.28-17244-gb58602a kernel that is the currently recent
> git code. The reiserfs fs has some major probs when booting this kernel. I just
> --rebuild-tree 4 partitions which are OK now again. When booting my Gentoo box
> says it cannot create an /etc/mtab~nnnn file and such. When I boot into stock
> 2.6.28, however, anything is OK. I re-tested that 3 times. Anytime I boot into
> the git kernel the messages occur and I shutdown the box via acpid (power
> button) as quick as I can.

Arrgh. See if that helps:

now that we use ih.key earlier, we need to do all its setup early enough

Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
---
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index 145c2d3..1306d4f 100644
--- a/fs/reiserfs/inode.c
+++ b/fs/reiserfs/inode.c
@@ -1782,6 +1782,12 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
goto out_bad_inode;
}
args.objectid = inode->i_ino = le32_to_cpu(ih.ih_key.k_objectid);
+ if (old_format_only(sb))
+ make_le_item_head(&ih, NULL, KEY_FORMAT_3_5, SD_OFFSET,
+ TYPE_STAT_DATA, SD_V1_SIZE, MAX_US_INT);
+ else
+ make_le_item_head(&ih, NULL, KEY_FORMAT_3_6, SD_OFFSET,
+ TYPE_STAT_DATA, SD_SIZE, MAX_US_INT);
memcpy(INODE_PKEY(inode), &(ih.ih_key), KEY_SIZE);
args.dirid = le32_to_cpu(ih.ih_key.k_dir_id);
if (insert_inode_locked4(inode, args.objectid,
@@ -1834,13 +1840,6 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
reiserfs_init_acl_default(inode);
reiserfs_init_xattr_rwsem(inode);

- if (old_format_only(sb))
- make_le_item_head(&ih, NULL, KEY_FORMAT_3_5, SD_OFFSET,
- TYPE_STAT_DATA, SD_V1_SIZE, MAX_US_INT);
- else
- make_le_item_head(&ih, NULL, KEY_FORMAT_3_6, SD_OFFSET,
- TYPE_STAT_DATA, SD_SIZE, MAX_US_INT);
-
/* key to search for correct place for new stat data */
_make_cpu_key(&key, KEY_FORMAT_3_6, le32_to_cpu(ih.ih_key.k_dir_id),
le32_to_cpu(ih.ih_key.k_objectid), SD_OFFSET,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/