Re: [PATCH 3/13] drivers/isdn/gigaset: use USB API functions ratherthan constants

From: Tilman Schmidt
Date: Mon Dec 29 2008 - 06:46:57 EST


On Mon, 29 Dec 2008 11:19:55 +0100 (CET), Julia Lawall wrote:
> This set of patches introduces calls to the following set of functions:
>
> usb_endpoint_dir_in(epd)
> usb_endpoint_dir_out(epd)
> usb_endpoint_is_bulk_in(epd)
> usb_endpoint_is_bulk_out(epd)
> usb_endpoint_is_int_in(epd)
> usb_endpoint_is_int_out(epd)
> usb_endpoint_num(epd)
> usb_endpoint_type(epd)
> usb_endpoint_xfer_bulk(epd)
> usb_endpoint_xfer_control(epd)
> usb_endpoint_xfer_int(epd)
> usb_endpoint_xfer_isoc(epd)
[...]
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

Acked-by: Tilman Schmidt <tilman@xxxxxxx>

Thanks,
Tilman

> ---
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index e847c6e..16399fb 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -783,7 +783,7 @@ static int gigaset_probe(struct usb_interface *interface,
> /* Fill the interrupt urb and send it to the core */
> usb_fill_int_urb(ucs->read_urb, udev,
> usb_rcvintpipe(udev,
> - endpoint->bEndpointAddress & 0x0f),
> + usb_endpoint_num(endpoint)),
> cs->inbuf[0].rcvbuf, buffer_size,
> gigaset_read_int_callback,
> cs->inbuf + 0, endpoint->bInterval);

--
Tilman Schmidt E-Mail: tilman@xxxxxxx
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

Attachment: signature.asc
Description: OpenPGP digital signature