Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider rangeof hardware

From: Nick Warne
Date: Mon Dec 29 2008 - 06:36:34 EST


On Wed, 12 Nov 2008 16:56:50 +0000
Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:

> Does this work?
>
> diff --git a/drivers/input/keyboard/atkbd.c
> b/drivers/input/keyboard/atkbd.c index 22016ca..15479ef 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1460,6 +1460,15 @@ static struct dmi_system_id
> atkbd_dmi_quirk_table[] __initdata = { .driver_data =
> atkbd_dell_laptop_keymap_fixup, },
> {
> + .ident = "Dell Laptop",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer
> Corporation"),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /*
> Portable */
> + },
> + .callback = atkbd_setup_fixup,
> + .driver_data = atkbd_dell_laptop_keymap_fixup,
> + },
> + {
> .ident = "HP 2133",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>

Hi Matthew,

I see this didn't make into the 2.6.28 release, and a lot of Ubuntu
users are being bitten by it - I also assume that the Ubuntu kernel
guys will not add it until it is officially applied, and they will then
backport it.

The Ubuntu bug report confirms this works OK for people:

https://bugs.launchpad.net/ubuntu/+source/acpid/+bug/285323

Nick
--
Free Software Foundation Associate Member 5508
http://linicks.net/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/