Re: [PATCH] clocksource: pass clocksource to read() callback

From: Magnus Damm
Date: Fri Dec 19 2008 - 05:02:58 EST


On Fri, Dec 19, 2008 at 5:11 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> It still blows up though. Any call to get_cycles() goes:
>
> crypto/tcrypt.c: In function `test_cipher_cycles':
> crypto/tcrypt.c:107: error: too few arguments to function
> crypto/tcrypt.c:112: error: too few arguments to function
> crypto/tcrypt.c: In function `test_hash_cycles_digest':
> crypto/tcrypt.c:305: error: too few arguments to function
> crypto/tcrypt.c:311: error: too few arguments to function
> crypto/tcrypt.c: In function `test_hash_cycles':
> crypto/tcrypt.c:361: error: too few arguments to function
> crypto/tcrypt.c:375: error: too few arguments to function
>
> because this:
>
> arch/sparc/include/asm/timex_64.h:#define get_cycles() tick_ops->get_tick()
>
> needs help.

Thanks for your help. I've now managed to build a sparc64 compiler and
make a fix. If it's ok with Dave then I think reverting the old
sparc64 hunks and go with a simple wrapper is the best, see the
attached patch.

/ magnus

Attachment: clocksource-pass-clocksource-to-read-callback-sparc64-fix-replacement.patch
Description: Binary data