Re: [PATCH] clocksource: pass clocksource to read() callback

From: Andrew Morton
Date: Fri Dec 19 2008 - 03:11:33 EST


On Thu, 18 Dec 2008 23:47:25 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 19 Dec 2008 16:30:36 +0900 "Magnus Damm" <magnus.damm@xxxxxxxxx> wrote:
>
> > > CHK include/linux/version.h
> > > CHK include/linux/utsrelease.h
> > > SYMLINK include/asm -> include/asm-sparc
> > > CC arch/sparc/kernel/asm-offsets.s
> > > In file included from include/linux/ktime.h:25,
> > > from include/linux/timer.h:5,
> > > from include/linux/clocksource.h:16,
> > > from /usr/src/devel/arch/sparc/include/asm/timer_64.h:11,
> > > from /usr/src/devel/arch/sparc/include/asm/timer.h:4,
> > > from /usr/src/devel/arch/sparc/include/asm/timex_64.h:9,
> > > from /usr/src/devel/arch/sparc/include/asm/timex.h:4,
> > > from include/linux/timex.h:170,
> > > from include/linux/sched.h:54,
> > > from arch/sparc/kernel/asm-offsets.c:13:
> > > include/linux/jiffies.h:247:31: warning: "CLOCK_TICK_RATE" is not defined
> > [lot's of warning snipped]
> >
> > How about the (unfortunately most likely mangled) patch below? Does it
> > help?
>
> yup.

It still blows up though. Any call to get_cycles() goes:

crypto/tcrypt.c: In function `test_cipher_cycles':
crypto/tcrypt.c:107: error: too few arguments to function
crypto/tcrypt.c:112: error: too few arguments to function
crypto/tcrypt.c: In function `test_hash_cycles_digest':
crypto/tcrypt.c:305: error: too few arguments to function
crypto/tcrypt.c:311: error: too few arguments to function
crypto/tcrypt.c: In function `test_hash_cycles':
crypto/tcrypt.c:361: error: too few arguments to function
crypto/tcrypt.c:375: error: too few arguments to function

because this:

arch/sparc/include/asm/timex_64.h:#define get_cycles() tick_ops->get_tick()

needs help.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/