Re: [PATCH] kbuild: fix CONFIG_EMBEDDED submenu

[Sam Ravnborg]

On Fri, Nov 28, 2008 at 11:41:59PM +0100, Vegard Nossum wrote:
> On Fri, Nov 28, 2008 at 6:38 PM, Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:
> > From 06f65799401f08eff0020ba0300133c89bd02349 Mon Sep 17 00:00:00 2001
> > From: Vegard Nossum <vegard.nossum@xxxxxxxxx>
> > Date: Fri, 28 Nov 2008 18:29:47 +0100
> > Subject: [PATCH] kbuild: fix CONFIG_EMBEDDED submenu
> >
> > Many of the elements of the EMBEDDED submenu were being expanded
> > in the current menu instead of inside the submenu. This was caused
> > by the lack of (explicit) dependencies on EMBEDDED. The simplest
> > fix is to wrap everything (except COMPAT_BRK, which just toggles a
> > setting) in "if/endif EMBEDDED".
> 
> Urgh -- the menu displays correctly, but defconfig now becomes totally
> wrong, because the items inside are taken to depend on EMBEDDED
> instead of toggling visibility. Better to add "if EMBEDDED" to the end
> of all the prompts, then.
> 
> That was counter-intuitive :-(

Thanks for the feedback Vegard!

I had it queued as I wanted to check if the conversion
from
	prompt "foo" if EMBEDDED

to
	depends on EMBEDDED

caused any signigicant difference. And so it did.

The fist uses EMBEDDED to say if the prompt is visible or not.
The latter say if this symbol can be set or not (overriding default)
as you experienced.

One day we should take a deeper look at the usage of EMBEDDED.
Replacing EMBEDDED with:

OPTIMIZE_FOR_TEXT_SIZE
OPTIMIZE_FOR_DATA_SIZE
KERNEL_EXPERT

would make it much more obvious what you could
achive by the individual options.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/