Re: [PATCH] kbuild: fix CONFIG_EMBEDDED submenu

[Vegard Nossum]

On Fri, Nov 28, 2008 at 6:38 PM, Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:
> From 06f65799401f08eff0020ba0300133c89bd02349 Mon Sep 17 00:00:00 2001
> From: Vegard Nossum <vegard.nossum@xxxxxxxxx>
> Date: Fri, 28 Nov 2008 18:29:47 +0100
> Subject: [PATCH] kbuild: fix CONFIG_EMBEDDED submenu
>
> Many of the elements of the EMBEDDED submenu were being expanded
> in the current menu instead of inside the submenu. This was caused
> by the lack of (explicit) dependencies on EMBEDDED. The simplest
> fix is to wrap everything (except COMPAT_BRK, which just toggles a
> setting) in "if/endif EMBEDDED".

Urgh -- the menu displays correctly, but defconfig now becomes totally
wrong, because the items inside are taken to depend on EMBEDDED
instead of toggling visibility. Better to add "if EMBEDDED" to the end
of all the prompts, then.

That was counter-intuitive :-(


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/