Re: [PATCH] 8250: Eliminate compile warning of 8250.c

From: Alan Cox
Date: Tue Nov 25 2008 - 06:13:45 EST


> The logic here is strange...

Why

> If you used old compiler, you would get a warning, and you thought that's
> ensured we won't delete a intended assignment by mistake.

No.. if you hid the warning by hacking around the compiler mistake with
extra bogus assignments you would hide a future mistake.
>
> If you used new compiler, you wouldn't get a warning, and you think this time
> the compiler get it right.

The compiler does now get it right - I checked.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/