Re: [GIT PATCH] USB fixes for 2.6.28-git

From: Junio C Hamano
Date: Tue Nov 25 2008 - 02:19:50 EST




Greg KH <gregkh@xxxxxxx> writes:

> On Mon, Nov 24, 2008 at 07:57:40PM -0800, Junio C Hamano wrote:
>>
>> Greg KH <gregkh-l3A5Bk7waGM@xxxxxxxxxxxxxxxx> writes:
>>
>> > On Thu, Nov 20, 2008 at 01:23:51PM -0800, Linus Torvalds wrote:
>> >> ...
>> >> "Already up-to-date".
>> >>
>> >> I think you forgot to actually push them out.
>> >
>> > Crap, you're right, they are now there, sorry about that.
>>
>> I've been wondering if git can do something to avoid things like this.
>> ...
> In this case, it was just my fault. I just forgot to push the tree. I
> have my own scripts that I use to create my "please pull" message, that
> don't really tie into git's infrastructure and I don't know if I would
> want them to either.

Oh, I wouldn't question that it was ultimately _your_ fault, but:

(1) I see Linus mention "did you forget to push" every once in a while
on this list (e.g. http://tinyurl.com/forgot-to-push); and

(2) You are not the only person who sends "please pull" request and
pushes out what needs to be pulled, and forgets to push. Everybody
who asks Linus to pull either needs to roll his own scripts. This is
wasteful, but this is partly git's fault, and something we could
improve, because I do not think there is no usable canned tools that
come with git that allows you to prepare a custom "please pull"
message and helps you not to forget pushing out; and

(3) As an early adopter who has his own wrappers around git that are
tailored to match his own needs in this part of the workflow, you'd
be an ideal source of requirements _if_ we would want to provide a
usable canned tool for doing this.

Hence my comments.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/