Re: [PATCH] __used is needed for function referenced only from inlineasm

[Török Edwin]

On 2008-11-24 11:04, Ingo Molnar wrote:
> * Török Edwin <edwintorok@xxxxxxxxx> wrote:
>
>   
>> According to the gcc manual, the 'used' attribute should be applied to
>> functions referenced only from inline assembly.
>> This fixes a build failure with llvm-gcc-4.2, which deleted
>> __mutex_lock_slowpath, __mutex_unlock_slowpath.
>>
>> Signed-off-by: Török Edwin <edwintorok@xxxxxxxxx>
>> ---
>>  kernel/mutex.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>     
>
> quite sad - it's gcc inline assembly after all - applied to 
> tip/core/locking (for v2.6.29).

Thanks.

>  Should this get into v2.6.28 too?
>   

It is up to you to decide. I'd say it can't hurt to have it in 2.6.28,
and patch looks trivial enough.

On the other hand it is not urgent either, building a full x86 kernel
with llvm-gcc only still has some loose ends
(there is something wrong with the boot code for example, like it can't
detect vga modes, I didn't figure out what is wrong yet)

Best regards,
--Edwin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/