Re: [PATCH] __used is needed for function referenced only from inline asm

[Andi Kleen]

On Mon, Nov 24, 2008 at 10:32:54AM +0100, Andreas Schwab wrote:
> Andi Kleen <andi@xxxxxxxxxxxxxx> writes:
> 
> > Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:
> >>>   */
> >>> -static void noinline __sched
> >>> +static __used noinline void __sched
> >>
> >> Perhaps we should incorporate it into `noinline'?
> >
> > No, we use noinline for other reasons too. Perhaps the other way
> > around though.
> 
> Or just drop noinline here (since there are no callers to inline into
> anyway).

That would seem fragile to me because it could hit later again when
someone changes the code or adds debugging code. Better always
have full annotations, even if you don't need them all at the moment.

-Andi

-- 
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/