Re: [PATCH 3/7] memcontrol: use simple_malloc()/simple_free()

From: David Miller
Date: Sun Nov 16 2008 - 03:16:46 EST


From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Date: Sun, 16 Nov 2008 07:51:28 +0300

> On Sun, Nov 16, 2008 at 12:33:46PM +0800, Lai Jiangshan wrote:
> > use simple_malloc()/simple_free() instead of current codes.
>
> struct mem_cgroup can't reach the size when kmalloc starts failing.

That's not the point.

When you got past a page, kmalloc/gfp allocations are less reliable,
and people also want NUMA spreading when possible.

That's why we use PAGE_SIZE as the table vmalloc() breakpoint. We do
this in many places already, with the exact same heuristics, and
for the exact same reasons.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/