Re: [PATCH 3/7] memcontrol: use simple_malloc()/simple_free()

[Lai Jiangshan]

Alexey Dobriyan wrote:
> On Sun, Nov 16, 2008 at 12:33:46PM +0800, Lai Jiangshan wrote:
>> use simple_malloc()/simple_free() instead of current codes.
> 
> struct mem_cgroup can't reach the size when kmalloc starts failing.

Good catch! Thanx!

compiler will optimize it and select the correct way.
using "simple_malloc()/simple_free()" here is no sense.

> 
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -1062,11 +1062,7 @@ static struct mem_cgroup *mem_cgroup_alloc(void)
>>  {
>>  	struct mem_cgroup *mem;
>>  
>> -	if (sizeof(*mem) < PAGE_SIZE)
>> -		mem = kmalloc(sizeof(*mem), GFP_KERNEL);
>> -	else
>> -		mem = vmalloc(sizeof(*mem));
>> -
>> +	mem = simple_malloc(sizeof(*mem));
>>  	if (mem)
>>  		memset(mem, 0, sizeof(*mem));
>>  	return mem;
>> @@ -1074,10 +1070,7 @@ static struct mem_cgroup *mem_cgroup_alloc(void)
>>  
>>  static void mem_cgroup_free(struct mem_cgroup *mem)
>>  {
>> -	if (sizeof(*mem) < PAGE_SIZE)
>> -		kfree(mem);
>> -	else
>> -		vfree(mem);
>> +	simple_free(mem);
>>  }
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/