Re: Subject: [PATCH 12/16] Squashfs: header files

From: Phillip Lougher
Date: Thu Oct 23 2008 - 04:56:23 EST

Geert Uytterhoeven wrote:
On Fri, 17 Oct 2008, Phillip Lougher wrote:

+#define TRACE(s, args...) printk(KERN_NOTICE "SQUASHFS: "s, ## args)
+#define TRACE(s, args...) {}

Just use

#define TRACE(s, args...) pr_debug("SQUASHFS: "s, ## args)


+#define WARNING(s, args...) printk(KERN_WARNING "SQUASHFS: "s, ## args)


SQUASHFS_MKFLAGS() isn't used by the kernel, only by the tools (mksquashfs)?

Only used by mksquashfs. I pulled out the user-space only stuff into a separate include, but must have missed this one.

+/* meta index cache */
+#define SQUASHFS_META_INDEXES (SQUASHFS_METADATA_SIZE / sizeof(unsigned int))
I was wondering whether a meta index is an `unsigned int' or an `__le32', but I
couldn't find it easily.

Unsigned int, it's used internally by the index cache code (file.c). It works out how many block indexes can fit into one compressed metadata block.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at