Re: Subject: [PATCH 09/16] Squashfs: uid/gid lookup operations

From: Geert Uytterhoeven
Date: Wed Oct 22 2008 - 12:38:49 EST


On Fri, 17 Oct 2008, Phillip Lougher wrote:
> --- /dev/null
> +++ b/fs/squashfs/id.c

> +__le64 *read_id_index_table(struct super_block *s, long long id_table_start,
> + unsigned short no_ids)
> +{
> + unsigned int length = SQUASHFS_ID_BLOCK_BYTES(no_ids);
> + __le64 *id_table;
> +
> + TRACE("In read_id_index_table, length %d\n", length);
> +
> + /* Allocate id index table */
> + id_table = kmalloc(length, GFP_KERNEL);
^^^^^^
Can this ever be larger than 64 KiB?

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village  Da Vincilaan 7-D1  B-1935 Zaventem  Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@xxxxxxxxxxx
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 Â RPR Brussels
Fortis  BIC GEBABEBB  IBAN BE41293037680010