Re: [PATCH 12/15 v5] PCI: support the SR-IOV capability

From: Zhao, Yu
Date: Tue Oct 21 2008 - 23:05:41 EST

Greg KH wrote:
On Tue, Oct 21, 2008 at 07:53:08PM +0800, Yu Zhao wrote:
Support Single Root I/O Virtualization (SR-IOV) capability.

Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Cc: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>
Cc: Alex Chiang <achiang@xxxxxx>
Cc: Matthew Wilcox <matthew@xxxxxx>
Cc: Roland Dreier <rdreier@xxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Yu Zhao <yu.zhao@xxxxxxxxx>

+#define iov_config_attr(field) \
+static ssize_t field##_show(struct device *dev, \
+ struct device_attribute *attr, char *buf) \
+{ \
+ struct pci_dev *pdev = to_pci_dev(dev); \
+ return sprintf(buf, "%d\n", pdev->iov->field); \

As you are adding new sysfs entries, can you also create the proper
documentation in Documentation/ABI/ so that people can understand how to
use them? Yes, I see you added a stand-alone document, but putting it
in the "standard" format is also necessary.

Thanks for reminding me about this. I used to update ABI doc in earlier versions, but somehow forgot to do this after several carry-forwards...

Will complete it in next version.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at