Re: [PATCH] byteorder: remove direct includes oflinux/byteorder/swab[b].h

From: Andrew Morton
Date: Tue Oct 21 2008 - 16:15:51 EST


On Mon, 20 Oct 2008 10:23:38 -0700
Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> A consolidated implementation will provide this generically through
> asm/byteorder, remove direct includes to avoid breakage when the
> changeover to the new implementation occurs.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> ---
> Andrew, this hunk seems to have been lost when you sent it to Linus, it's possible
> you applied this on top of the -next tree where this file has moved, but the tests
> tree hasn't been pulled yet.
>
> The rest of the patch went into mainline as 1d8cca44b6a244b7e378546d719041819049a0f9
>

Grump. It happens sometimes. People putting stuff into linux-next and
then not merging it into the next kernel.

>
> kernel/rcutorture.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index 90b5b12..85cb905 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -42,10 +42,10 @@
> #include <linux/freezer.h>
> #include <linux/cpu.h>
> #include <linux/delay.h>
> -#include <linux/byteorder/swabb.h>
> #include <linux/stat.h>
> #include <linux/srcu.h>
> #include <linux/slab.h>
> +#include <asm/byteorder.h>

Should this be linux/byteorder.h? (Which weirdly doesn't include
asm/byteorder.h).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/