Re: [PATCH] sparc: correct section of apc_no_idle

[Frédéric Weisbecker]

2008/10/18 Frederic Weisbecker <fweisbec@xxxxxxxxx>:
> The latest mainline gives this section mismatch on sparc:
>
> The function __devinit apc_probe() references
> a variable __initdata apc_no_idle.
> If apc_no_idle is only used by apc_probe then
> annotate apc_no_idle with a matching annotation.
>
> Since the commit 7e7e2f035663c5ceb029bfb9d91e75099b0a5625,
> apc_probe() is on __devinit so we have to correct apc_no_idle
> which is referenced by this function.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
> diff --git a/arch/sparc/kernel/apc.c b/arch/sparc/kernel/apc.c
> index 4dd1ba7..9c11582 100644
> --- a/arch/sparc/kernel/apc.c
> +++ b/arch/sparc/kernel/apc.c
> @@ -31,7 +31,7 @@
>  #define APC_DEVNAME "apc"
>
>  static u8 __iomem *regs;
> -static int apc_no_idle __initdata = 0;
> +static int apc_no_idle __devinitdata = 0;
>
>  #define apc_readb(offs)                (sbus_readb(regs+offs))
>  #define apc_writeb(val, offs)  (sbus_writeb(val, regs+offs))
>

(Adding William and sparclinux in cc)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/