Re: [git pull] drm patches for 2.6.27-rc1
From: Jesse Barnes
Date: Mon Oct 20 2008 - 16:04:29 EST
On Friday, October 17, 2008 7:10 pm Eric Anholt wrote:
> On Fri, 2008-10-17 at 15:43 -0700, Linus Torvalds wrote:
> > On Fri, 17 Oct 2008, Dave Airlie wrote:
> > So what's the excuse _this_ time for adding all these stupid warnings to
> > my build log? Did nobody test this?
> > drivers/gpu/drm/drm_proc.c: In function âdrm_gem_one_name_infoâ:
> > drivers/gpu/drm/drm_proc.c:525: warning: format â%dâ expects type
> > âintâ, but argument 3 has type âsize_tâ drivers/gpu/drm/drm_proc.c:533:
> > warning: format â%9dâ expects type âintâ, but argument 4 has type
> > âsize_tâ drivers/gpu/drm/i915/i915_gem.c: In function
> > âi915_gem_gtt_pwriteâ: drivers/gpu/drm/i915/i915_gem.c:184: warning:
> > unused variable âvaddr_atomicâ
> Yeah, none of us are on x86-64, so we missed those warnings in testing.
Actually, I'm on x86_64 pretty much exclusively and saw these warnings last
week. But I didn't send a fix (yet); sorry.
That said, this code was far from untested, even though it did contain a few
compile warnings, so I think Linus's complaint about UNTESTED CRAP was at
least half wrong.
Jesse Barnes, Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/