Re: [PATCH] User namespaces: set of cleanups (eventually forlinux-next?)

From: Serge E. Hallyn
Date: Mon Oct 20 2008 - 14:51:53 EST


Quoting David Howells (dhowells@xxxxxxxxxx):
>
> Serge E. Hallyn <serue@xxxxxxxxxx> wrote:
>
> > David, since this consumes your patch, I wasn't sure whether it was
> > appropriate to put your signed-off-by on here or not. I decided
> > doing so was the worse of the potential offenses...
>
> The way I think I'd've done it is to include my patch description and
> signed-off-by then list your additional changes (just keep on incrementing the
> point numbers) and your signed-off-by.
>
> > - new_user = alloc_uid(current->nsproxy->user_ns, new->uid);
> > + new_user = alloc_uid(current_user()->user_ns, new->uid);
>
> That should be current_user_ns() rather than current_user()->user_ns. I made
> this change before adding the macro.

Ok, will change.

> > + key_put(new->thread_keyring);
> > + new->thread_keyring = NULL;
>
> Superfluous. copy_creds() does this immediately upon return.

Oops, will drop.

> Also, in copy_creds(), should the session and process keyrings be discarded if
> CLONE_NEWUSER is set? Actually, I think that should be dealt with by a patch
> to deal with namespacing keyrings as the user-default keyrings need to be
> namespaced rather than here.
>
> David

Oh, yeah, that's going to have to be a separate patch I guess...

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/