Re: [PATCH] Enable console on PCI serial devices
From: Bjorn Helgaas
Date: Mon Oct 20 2008 - 13:22:34 EST
On Monday 20 October 2008 10:44:04 am Lennart Sorensen wrote:
> On Fri, Oct 17, 2008 at 11:06:38AM -0600, n0ano@xxxxxxxxx wrote:
> > We could do that but now the `clock' value becomes a very large
> > number that is very magic. Putting in the highest baud rate seems
> > to make more sense than some magic number.
> Yeah, and isn't that usually called the base_baud or something like
It doesn't bother me that the number is large. It's only a factor
of 16 bigger than the baud rate. It is sort of magic, but on the
other hand, the number is often printed on a part on the board, so
it's easy to determine, and fairly easy to document. If you've
lost the box with the marketing messages on it, I'd argue that it's
easier to determine the clock rate than the fastest baud rate.
To me it seems more confusing to specify two baud rates: the one
you want to use, and the fastest one the UART supports.
Bjorn "i want my bike shed *blue*" :-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/