Re: [PATCH 0/2] ftrace: fixes for PPC
From: Steven Rostedt
Date: Mon Oct 20 2008 - 12:30:44 EST
On Thu, 16 Oct 2008, Josh Boyer wrote:
> > On Thu, 16 Oct 2008, Josh Boyer wrote:
> > >
> > > Well, that's why I asked. You sent 2 patches out over a month ago that
> > > don't appear to have shown up in any Linus or PowerPC tree.
> > Oh, the patches I sent on here, are not to solve this issue. It was
> > actually solving issues in linux-tip itself.
> Totally confused as to what linux-tip is, but ok.
> > I'm still looking into the cause for ftrace not to boot on PPC.
> There were issues with -pg and some other compile flag on PPC at one
> point. I think you worked that out with Ben, but I don't recall.
> Anyway, if you want a tester let me know. It seems 184.108.40.206 should be
> fine since FTRACE was disabled, but for .28-rc1 it would be cool if it
> worked :).
I've been looking deeper at the code for PPC. I realized that my PPC64 box
that I've been testing on did not use modules. While looking at the module
code it dawned on me the dynamic ftrace needs a bit of work. This is
because the way modules are handled in PPC (and other architectures as
well). The jmps used by mcount is a 24 bit jump. Since the modules are
loaded farther than 24bits away, a trampoline is needed.
A bit of rework is needed in the ftrace infrastructure to handle the
trampoline. Too much work to go into 28. I'll start working on code that
can hopefully be ready and tested for 29. It's not that major of a change,
but since the merge window for 28 has already been opened, we would like
to get a bit more testing in before we hand it over to Linus.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/