Re: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove}calls

From: Anton Vorontsov
Date: Fri Oct 17 2008 - 17:13:28 EST

On Fri, Oct 17, 2008 at 01:25:01PM -0700, David Brownell wrote:
> On Thursday 16 October 2008, Anton Vorontsov wrote:
> > +       if (of_gc->chip)
> > +               return of_gc->chip;
> > +       return &of_gc->gc;
> presumably there's a reason not to
> of_gc->chip = &of_gc->gc;

Yes, there are two reasons:

1. I need some place to insert the huge comment, which you snipped. ;-)

2. I didn't want to break current users. That is, the line you purpose
("of_gc->chip = &of_gc->gc;") should be inserted to every of_gpio
controller. Most of them use of_mm_gpiochip_add(), so these are easy.
But some (mcu_mpc8349emitx.c) are doing things by themselves.


Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at