Re: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls

From: David Brownell
Date: Fri Oct 17 2008 - 16:32:23 EST

On Thursday 16 October 2008, Anton Vorontsov wrote:
> +       if (of_gc->chip)
> +               return of_gc->chip;
> +       return &of_gc->gc;

presumably there's a reason not to

of_gc->chip = &of_gc->gc;

when this gets set up, so this can always be a simple

return of_gc->chip;

(and inlined)? Needlessly complex...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at