Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomicloading firmware with PCMCIA adapter

[Dominik Brodowski]

Hi,

On Fri, Oct 10, 2008 at 09:26:30PM +0400, Andrey Borzenkov wrote:
> On Friday 10 October 2008, Dave wrote:
> > 
> > Andrey Borzenkov wrote:
> > > On Friday 10 October 2008, Dave wrote:
> > >> You're right. pda_size is supposed to be the maximum size of the PDA (in bytes) that we expect with the firmware. It should be set to 0x200.
> > >>
> > > 
> > > Do you want me to send a patch?
> > 
> > Could you fix it as part of the patch you submitted?
> > 
> 
> Attached. As other entries use decimal I thought it is more logical
> to use 512 as well.

> Subject: [PATCH] orinoco: reduce stack usage in firmware download path
> From: Andrey Borzenkov < arvidjaar@xxxxxxx>
> 
> orinoco_dl_firmware and symbol_dl_mage allocate large local
> variables (1K); at least orinoco fails with panic or hung
> kernel if 4K stacks is enabled.
> 
> Allocate large buffers dynamically at run time.
> 
> Tested-By: Andrey Borzenkov <arvidjaar@xxxxxxx> for Agere case
> 
> Signed-off-by: Andrey Borzenkov < arvidjaar@xxxxxxx>
Acked-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

I assmue this is to be merged via wireless and net, and not via pcmcia?

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/