Re: GIT head no longer boots on x86-64

[Linus Torvalds]

On Wed, 15 Oct 2008, Ingo Molnar wrote:
> 
> Queued the fix below up in tip/x86/urgent for a merge to Linus later 
> today. Thanks!

Please don't send this crap to me.

Guys, _look_ at the patch for one second. And then tell me it isn't crap. 

The question is: "Is this a vmalloc'ed area?". That's the name of the 
function. AND YOU JUST BROKE IT!

Fix the damn caller instead. Don't make x86-64-specific changes to a 
generic function that breaks the whole meaning of the function. I don't 
understand what the hell is wrong with you people - we don't fix bugs by 
introducing idiocies, we fix them by fixing the code.

EVEN YOUR COMMIT MESSAGE should have made this obvious.

The code in question already does

	VIRTUAL_BUG_ON(!is_vmalloc_addr(vmalloc_addr) &&
                       !is_module_address(addr));

and look at that thing and ask yourself: where was the bug again.

And dammit, if you say it was in "is_vmalloc_addr()", I can only shake my 
head.

Please guys. Use some taste. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/