Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress somewarnings on Blackfin

From: David Miller
Date: Mon Oct 13 2008 - 06:14:33 EST


From: Bryan Wu <cooloney@xxxxxxxxxx>
Date: Mon, 13 Oct 2008 17:10:09 +0800

> From: Javier Herrero <jherrero@xxxxxxxxxxxxx>
>
> Signed-off-by: Javier Herrero <jherrero@xxxxxxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>

This is not only inelegant, it'll likely break things on
64-bit MIPS or any other case where the upper 32-bit matter.

I'd rather see Blackfin fix it's I/O accessor prototypes
to take a proper __iomem pointer.

This patch won't be applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/