Re: [PATCH v2] ftrace: Add a C-state tracer to help poweroptimization

[Arjan van de Ven]

On Mon, 06 Oct 2008 18:52:39 +0200
Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> >  
> > 
> >  #endif /* _LINUX_FTRACE_H */
> 
> Why have the cstate_trace structure? If you just log start, stop you
> could compute the time delta from the trace time stamps, no?

there's 2 other fields I need than just the timestamp.
> 
> If you decide to keep the structure, perhaps declare it empty for !
> CONFIG_CSTATE_TRACER so as to not bloat stack usage when its not
> configured.

ok good point

> 


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/