Re: [PATCH -tip] sdhci: 'scratch' may be used uninitialized

From: Steven Noonan
Date: Wed Oct 01 2008 - 04:33:29 EST


On Wed, Oct 1, 2008 at 1:14 AM, Steven Noonan <steven@xxxxxxxxxxxxxx> wrote:
> - u32 scratch;
> + u32 uninitialized_var(scratch);

A bit of a further explanation:

The variable 'scratch' is always initialized before it's used. The
conditional which is responsible for initialization of 'scratch' will
always evaluate 'true' when the first loop iteration occurs, and thus,
it's properly initialized. GCC doesn't see this, of course, so using
the uninitialized_var() macro seems to work for silencing this case.

- Steven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/