Re: [PATCH -tip] pcm_native: label out defined but not used

[Ingo Molnar]

* Takashi Iwai <tiwai@xxxxxxx> wrote:

> At Wed, 1 Oct 2008 09:59:21 +0200,
> Ingo Molnar wrote:
> > 
> > 
> > (Cc:-ed Taskashi for this ALSA cleanup patch.)
> 
> This label is used when the debug option is enabled.

ah, indeed:

        snd_assert(substream != NULL, goto out);

if then i'd suggest to clean it up like this:

        if (snd_assert(substream != NULL))
		goto out;

this is how DEBUG_LOCKS_WARN_ON() is used in kernel/lockdep.c for 
example. Putting code flow side-effects into debug macros looks a bit 
weird.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/