Re: [PATCH] avr32: clean up mci platform code

From: Haavard Skinnemoen
Date: Fri Jul 18 2008 - 05:05:18 EST

On Fri, 18 Jul 2008 16:48:09 +1000
Ben Nizette <bn@xxxxxxxxxxxxxxx> wrote:

> This patch does a few small cleanups around the atmel mci platform code
> and in the atmel-mci driver. The platform changes simply removes an
> unused variable, uses the fact that by the end we always have some form
> of platform data and notes that GPIO_PIN_NONE != 0. This last point
> could cause the incorrect attempt to twice reserve pin PA0.

Indeed. The if (data) check is useless too since we make sure data
always points to something.

We should probably set the invalid pins to something like -EINVAL
eventually, but for now GPIO_PIN_NONE is consistent with everything
else around there.

> While we've got the hood up, add linux/err.h to the atmel-mci.c include
> list. It needs it and generally pulls it by voodoo but I did once
> stumble across a config which don't build.

Yes, including linux/err.h is definitely the right thing to do.

> This is against Linus' latest git.
> Signed-off-by: Ben Nizette <bn@xxxxxxxxxxxxxxx>

I've applied it to the avr32 tree since it touches mostly avr32 arch
code. Thanks a lot, Ben!

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at