Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

From: David Miller
Date: Thu Jul 17 2008 - 17:38:16 EST


From: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>
Date: Thu, 17 Jul 2008 22:04:14 +0200

> Hello,
>
> > +#define SPEED_0 0xffff
> > +#define SPEED_10 10
> > +#define SPEED_100 100
> > +#define SPEED_100 100
>
> Small thing - double define for SPEED_100.
>
> > +#define SPEED_1000 1000

And these are all entirely superfluous, since they are already defined
in linux/ethtool.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/