Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

From: Ben Hutchings
Date: Thu Jul 17 2008 - 16:23:31 EST


Mariusz Kozlowski wrote:
> Hello,
>
> > +#define SPEED_0 0xffff
> > +#define SPEED_10 10
> > +#define SPEED_100 100
> > +#define SPEED_100 100
>
> Small thing - double define for SPEED_100.
>
> > +#define SPEED_1000 1000

In fact these are all duplicates of macros defined in <linux/ethtool.h>
(except SPEED_0, whatever that means).

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/