Re: [PATCH] x86: traps and do_traps under one hood

From: Jaswinder Singh
Date: Tue Jul 15 2008 - 11:55:17 EST


Hello ïAlexander,

On Tue, 2008-07-15 at 15:51 +0200, Alexander van Heukelum wrote:

>
> I think moving the declarations to a header file is a good thing,
> but I don't think mach_traps.h is a suitable place.

ïI CC new patch to you : [PATCH] x86: Introducing asm-x86/traps.h

> The definitions
> of the functions are in entry_32.S and entry_64.S, so I would suggest
> making a new header include/asm-x86/entry.h. Some other ENTRY's
> (like system_call and some xen-specific ones) would then also fit
> in this header.
>
> What do you think?

I did this for traps_32.c and traps_64.c because they are complaining
that traps are defined but not declared.

Thank you,

Jaswinder Singh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/