Re: [GIT *] Allow request_firmware() to be satisfied fromin-kernel, use it in more drivers.

From: Benjamin Herrenschmidt
Date: Tue Jul 15 2008 - 01:20:10 EST


On Mon, 2008-07-14 at 17:44 -0700, David Woodhouse wrote:
> On Mon, 2008-07-14 at 17:40 -0700, Linus Torvalds wrote:
> >
> > On Mon, 14 Jul 2008, David Woodhouse wrote:
> > >
> > > I see no real point in that. If you have userspace to load modules, then
> > > you have userspace to load firmware.
> >
> > David, the case is different: the module is loaded _across_ the
> > suspend/resume, but the device needs to have its firmware reloaded at
> > resume time because it lost power.
>
> Either I put my reply in response to the wrong quotation, or you thought
> I did.
>
> I intended the above to be a response to the "please put firmware _into_
> the .ko file" request. Not to the suspend/resume thing.
>
> Yes, I agree that suspend/resume is a non-issue.

Besides, request_firmware() from a resume() method is broken. Has always
been and will probably always be.

Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/