Re: [PATCH] x86: let 32bit use apic_ops too

From: Maciej W. Rozycki
Date: Sat Jul 12 2008 - 21:55:43 EST


On Sat, 12 Jul 2008, Yinghai Lu wrote:

> > Etc... Why are you changing names of these functions? Are they meant
> > not to apply to older APIC implementations anymore?
>
> because 64bit has that name.

Shouldn't it be the other way round then? Our 32-bit code is the
original one and supports more APIC variations than the 64-bit one. So at
the point of unification 64-bit xAPIC-only functions will become universal
ones making the naming counter-intuitive: apic_ -> any APIC, xapic_ ->
xAPIC only. I think only functions specific to the xAPIC should have the
xapic_ prefix.

Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/