Re: [PATCH linux-next 1/1] cris: look for linker scripts in srctree not in objtree

[Sam Ravnborg]

On Tue, Jul 01, 2008 at 06:02:41PM +0200, Jesper Nilsson wrote:
> Hi!
> 
> On Tue, Jul 01, 2008 at 04:08:44PM +0200, Hinko Kocevar wrote:
> > When building kernel with O= linker looks for linker scripts in output tree, while they are located in source tree.
> >
> > Signed-off-by: Hinko Kocevar <hinko.kocevar@xxxxxxxxxxxx>
> 
> I think this would be cleaner:
> 
> diff --git a/arch/cris/arch-v10/boot/compressed/Makefile b/arch/cris/arch-v10/boot/compressed/Makefile
> --- a/arch/cris/arch-v10/boot/compressed/Makefile
> +++ b/arch/cris/arch-v10/boot/compressed/Makefile
> @@ -4,7 +4,7 @@
>  
>  asflags-y += $(LINUXINCLUDE)
>  ccflags-y += -O2 $(LINUXINCLUDE)
> -ldflags-y += -T $(obj)/decompress.ld
> +ldflags-y += -T $(srctree)/$(src)/decompress.ld
>  OBJECTS = $(obj)/head.o $(obj)/misc.o
>  OBJCOPYFLAGS = -O binary --remove-section=.bss
>  

linker scripts are by definition named *.lds in the kernel.
And if you need to preprocess them then name them *.lds.S as
we do in arch/$ARCH/kernel/*

As this is not a generated linker script then the $(srctree)/$(src) prefix
is correct and the $(obj) prefix was plain wrong.

So:
Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/