Re: [PATCH 15/39] don't save ebx in putuser_32.S

From: Glauber Costa
Date: Mon Jun 30 2008 - 16:44:58 EST


Andi Kleen wrote:
Glauber Costa <gcosta@xxxxxxxxxx> writes:

clobber it in the inline asm macros, and let the compiler do this for us.

I would expect that definitely will cause code size regressions ...

-Andi

Andi,

Thanks for reviewing my patches.

Although I agree with you, I think the reduced codesize is not enough a reason to keep code duplicated. If you can provide a version of it that is granted to reduce the code size for both i386 and x86_64, or even one that makes it minimal for x86_64 and yet, works with i386, fine.

Otherwise, I still think this is the best option.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/