Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY supportsOLPC

From: Andrew Morton
Date: Thu Jun 05 2008 - 15:43:53 EST


On Thu, 5 Jun 2008 15:29:14 -0400
Andres Salomon <dilinger@xxxxxxxxxx> wrote:

> Previously, one would have to specifically choose CONFIG_OLPC and
> CONFIG_PCI_GOOLPC in order to enable PCI_OLPC. That doesn't really
> work for distro kernels, so this patch allows one to choose
> CONFIG_OLPC and CONFIG_PCI_GOANY in order to build in OLPC support in
> a generic kernel (as requested by Robert Millan).
>
> This also moves GOOLPC before GOANY in the menuconfig list.
>
> Finally, make pci_access_init return early if we detect OLPC hardware.
> There's no need to continue probing stuff, and pci_pcbios_init
> specifically trashes our settings (we didn't run into that before
> because PCI_GOANY wasn't supported).
>
> It would be great if we could sneak this in for 2.6.26.. *cough* :)
>

It looks harmless enough.

> ---
> arch/x86/Kconfig | 11 +++++------
> arch/x86/pci/init.c | 3 ++-
> arch/x86/pci/olpc.c | 5 +++--
> arch/x86/pci/pci.h | 2 +-

But I never know whether arch/x86/pci is a Jesse thing or an Ingo
thing. Usual answer: it's an everyone thing and we all make a big mess ;)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/