Re: [PATCH] scsi: remove CDROM not ready printk

From: Matthew Wilcox
Date: Thu May 29 2008 - 10:51:44 EST


On Thu, May 29, 2008 at 10:35:08AM -0400, Gerb Stralko wrote:
> On Thu, May 29, 2008 at 10:05 AM, James Bottomley
> <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > That's correct. cgc is the data from the packet command that was sent
> > in from the ioctl. The user application is actually the one that
> > decides whether you get to see the message or not. Modern apps like hal
> > set it because they take care of all state updates and notifications
> > themselves. Which is the application that's doing this (because it
> > probably needs updating).
>
> So is that printk really needed? Should the kernel even need to print
> a message like that, esp. if user-space is handling state updates and
> notifications. Or do i need to configure hald to be quietier? FWIW
> I'm using fedora core 9 and hald version:
> -bash-3.2$ /usr/sbin/hald --version
> HAL package version: 0.5.11

I think you misunderstood. James is saying that an app like HAL will
set the ->quiet flag. You must be using some other application that
isn't setting the ->quiet flag. Any idea what this other application
is?

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/