Re: [PATCH] scsi: remove CDROM not ready printk

[Gerb Stralko]

On Thu, May 29, 2008 at 10:05 AM, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 2008-05-29 at 00:41 -0700, Andrew Morton wrote:
>> On Tue, 27 May 2008 15:02:43 -0400 (EDT) Jerry Stralko <gerb.stralko@xxxxxxxxx> wrote:
>>
>> > Hello,
>>
>> let's cc a scsi list which exists ;)
>>
>> >    This printk was spamming my dmesg and /var/log/message.  Is there a
>> > reason we have this printk?  Can we simply remove it?
>> >
>> >
>> > Signed-off-by: Jerry Stralko <gerb.stralko@xxxxxxxxx>
>> > ---
>> >
>> >
>> > diff --git a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
>> > index ae87d08..c37fb1c 100644
>> > --- a/drivers/scsi/sr_ioctl.c
>> > +++ b/drivers/scsi/sr_ioctl.c
>> > @@ -238,8 +238,6 @@ int sr_do_ioctl(Scsi_CD *cd, struct packet_command *cgc)
>> >                                     break;
>> >                             }
>> >                     }
>> > -                   if (!cgc->quiet)
>> > -                           printk(KERN_INFO "%s: CDROM not ready.  Make sure there is a disc in the drive.\n", cd->cdi.name);
>> >   #ifdef DEBUG
>> >                     scsi_print_sense_hdr("sr", &sshdr);
>> >   #endif
>>
>> The answer may be that you need to enable cgc->quiet.  If that is
>> user-enableable - I can't work out how from a quick grep.
>
> That's correct.  cgc is the data from the packet command that was sent
> in from the ioctl.  The user application is actually the one that
> decides whether you get to see the message or not.  Modern apps like hal
> set it because they take care of all state updates and notifications
> themselves.  Which is the application that's doing this (because it
> probably needs updating).
>
> James

So is that printk really needed?  Should the kernel even need to print
a message like that, esp. if user-space is handling state updates and
notifications.  Or do i need to configure hald to be quietier?   FWIW
I'm using fedora core 9 and hald version:
-bash-3.2$ /usr/sbin/hald --version
HAL package version: 0.5.11

thanks,

Jerry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/